Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add reference to adapter for micro #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oklas wants to merge 2 commits into node-oauth:development from oklas:master

Conversation

@oklas
Copy link
Contributor

@oklas oklas commented Oct 8, 2021

No description provided.

Copy link
Member

HappyZombies commented Oct 8, 2021
edited
Loading

Looks good but a couple of things:

  1. Docs here will be different and need to be hosted than from the original repo, so we need to discuss and decide how and where we wanna host THESE docs.
  2. I am not sure if I want people making MRs to master yet, gotta discuss a merging first.

Once we get those stuff resolved I'll gladly merge this PR.

Copy link
Member

Thank you @oklas I have a provocative question. How do you see adding your package to this organization an continue maintaining it under this org? It's your decision, I just think we can build more trust when also keeping the adapters maintained under this org (in case you will one day have no time to maintain). What do you think?

@oklas oklas closed this Oct 11, 2021
@oklas oklas reopened this Oct 11, 2021
@oklas oklas changed the base branch from master to development October 11, 2021 13:38
@HappyZombies HappyZombies added awaiting more info 💭 More information is needed documentation 📑 Improvements or additions to documentation labels Oct 13, 2021
Copy link
Member

I'm going to close this pull request since there is no response anymore.

In my opinion, adapters need to redirect to this repository instead of an old one that is been stale for 5 years. We should set this as a hard requirement to be referenced in this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting more info 💭 More information is needed documentation 📑 Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /